Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 2.7's numbered parameter for Style/RedundantSort #7783

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 8, 2020

This PR supports Ruby 2.7's numbered parameter for Style/RedundantSort.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR supports Ruby 2.7's numbered parameter for `Style/RedundantSort`
@koic koic force-pushed the fix_a_false_negative_for_style_redundant_sort branch from 6bea934 to 03a03dd Compare Mar 10, 2020
@koic koic changed the title Fix a false negative for Style/RedundantSort Support Ruby 2.7's numbered parameter for Style/RedundantSort Mar 10, 2020
@bbatsov bbatsov merged commit dccf875 into rubocop:master Mar 19, 2020
25 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 19, 2020

Thanks!

@koic koic deleted the fix_a_false_negative_for_style_redundant_sort branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants