Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 2.7's numbered parameter for Lint/SafeNavigationChain #7784

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 8, 2020

This PR supports Ruby 2.7's numbered parameter for Lint/SafeNavigationChain.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic changed the title Fix a false negative for Lint/SafeNavigationChain Support Ruby 2.7's numbered parameter for Lint/SafeNavigationChain Mar 10, 2020
@koic koic force-pushed the fix_a_false_negative_for_lint_safe_navigation_chain branch from 67613d6 to 08a5371 Compare Mar 10, 2020
@koic koic force-pushed the fix_a_false_negative_for_lint_safe_navigation_chain branch from 08a5371 to eea3e09 Compare Mar 19, 2020
This PR supports Ruby 2.7's numbered parameter for `Lint/SafeNavigationChain`.
@koic koic force-pushed the fix_a_false_negative_for_lint_safe_navigation_chain branch from eea3e09 to 212c12d Compare Mar 19, 2020
@koic koic merged commit 90eb2a0 into rubocop:master Mar 19, 2020
25 checks passed
@koic koic deleted the fix_a_false_negative_for_lint_safe_navigation_chain branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants