Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer include? over member? in Style/CollectionMethods #7793

Merged
merged 1 commit into from Mar 12, 2020
Merged

Prefer include? over member? in Style/CollectionMethods #7793

merged 1 commit into from Mar 12, 2020

Conversation

dmolesUC
Copy link
Contributor

@dmolesUC dmolesUC commented Mar 11, 2020

Updates Style/CollectionMethods cop to prefer include? over member?.

Per ruby-style-guide#804.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@koic
Copy link
Member

koic commented Mar 11, 2020

Can you update the following StyleGuide value for the rule of The Ruby Style Guide?

diff --git a/config/default.yml b/config/default.yml
index 5049f96a1..18ac0e7f8 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -2455,7 +2455,7 @@ Style/ClassVars:
 # Align with the style guide.
 Style/CollectionMethods:
   Description: 'Preferred collection methods.'
-  StyleGuide: '#map-find-select-reduce-size'
+  StyleGuide: '#map-find-select-reduce-include-size
   Enabled: false
   VersionAdded: '0.9'
   VersionChanged: '0.27'

https://github.com/rubocop-hq/ruby-style-guide#map-find-select-reduce-include-size

koic
koic approved these changes Mar 12, 2020
@koic
Copy link
Member

koic commented Mar 12, 2020

I'm going to merge this PR because Appvayor CI failure is probably a false positive. Thank you!

@koic koic merged commit 24d097b into rubocop:master Mar 12, 2020
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants