Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode-display_width 1.7.0 #7797

Merged
merged 1 commit into from Mar 12, 2020
Merged

Allow unicode-display_width 1.7.0 #7797

merged 1 commit into from Mar 12, 2020

Conversation

yuritomanek
Copy link
Contributor

@yuritomanek yuritomanek commented Mar 12, 2020

Updating rubocop.gemspec to allow unicode-display_width:1.7.0

All tests pass against version 1.7.0, so we assume that there are no breaking changes and the dependency is safe to update.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

CHANGELOG.md Show resolved Hide resolved
rubocop.gemspec Outdated Show resolved Hide resolved
@koic
Copy link
Member

koic commented Mar 12, 2020

This looks good to me. Can you squash your commits into one?

@yuritomanek
Copy link
Contributor Author

yuritomanek commented Mar 12, 2020

@koic No problem 👍

@koic koic merged commit 129b014 into rubocop:master Mar 12, 2020
25 checks passed
@koic
Copy link
Member

koic commented Mar 12, 2020

Thanks!

@yuritomanek yuritomanek deleted the bugfix/allow-unicode-display_width-1.7.0 branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants