Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 2.7's numbered parameter for Style/Lambda #7816

Merged
merged 1 commit into from Mar 26, 2020

Conversation

koic
Copy link
Member

@koic koic commented Mar 23, 2020

This PR supports Ruby 2.7's numbered parameter for Style/Lambda.

And this PR maps numblock to BlockNode.
I considered the introduction of NumblockNode, but most will overlap with BlockNode. IMHO, probably NumblockNode class does not need to be split now.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the support_numblock_type branch from 13e8f99 to a2c5261 Compare Mar 24, 2020
This PR supports Ruby 2.7's numbered parameter for `Style/Lambda`.

And this PR maps `numblock` to `BlockNode`.
I considered the introduction of `NumblockNode`, but most will overlap
with `BlockNode`. IMHO, probably `NumblockNode` class does not need
to be split now.
@koic koic force-pushed the support_numblock_type branch from a2c5261 to 500d0c5 Compare Mar 26, 2020
@koic koic merged commit 95e75ca into rubocop:master Mar 26, 2020
25 checks passed
@koic koic deleted the support_numblock_type branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants