Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/NestedParenthesizedCalls docs #7822

Merged
merged 2 commits into from Mar 31, 2020
Merged

Conversation

igor-drozdov
Copy link
Contributor

@igor-drozdov igor-drozdov commented Mar 25, 2020

method1(method2 arg, method3, arg) is not equivalent to method1(method2 arg, method3, arg)

method1(method2 arg, method3 arg) would be incorrect as well

method1(method2 arg) vs method1(method2(arg)) would be an example that illustrates the code standards and is correct in terms of syntax


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

method1(method2 arg, method3, arg) is not equivalent to method1(method2 arg, method3, arg)
@koic
Copy link
Member

koic commented Mar 26, 2020

CI has failed. Can you run rake generate_cops_documentation and apply it?

@koic
Copy link
Member

koic commented Mar 27, 2020

This looks good to me. Can you squash your commits into one?

@bbatsov bbatsov merged commit 51de04e into rubocop:master Mar 31, 2020
25 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 31, 2020

I squashed on merge.

saurabhmaurya15 pushed a commit to saurabhmaurya15/rubocop that referenced this issue Apr 7, 2020
method1(method2 arg, method3, arg) is not equivalent to method1(method2 arg, method3, arg)
Neodelf pushed a commit to Neodelf/rubocop that referenced this issue Apr 28, 2020
method1(method2 arg, method3, arg) is not equivalent to method1(method2 arg, method3, arg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants