Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop-packaging as a known extension in the docs #8160

Merged
merged 1 commit into from Jun 18, 2020

Conversation

utkarsh2102
Copy link
Member

This PR adds another known extension, rubocop-packaging to the extension docs.

And lastly, thanks @bbatsov, for this wonderful tool! ❤️

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

CHANGELOG.md Outdated Show resolved Hide resolved
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 17, 2020

Cool package! I've always been fond of Debian! :-)

And lastly, thanks @bbatsov, for this wonderful tool! ❤️

You're welcome! 🙇‍♂️

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
@utkarsh2102
Copy link
Member Author

Cool package! I've always been fond of Debian! :-)

Awesome, thanks! 😄

@bbatsov bbatsov merged commit 6e270b5 into rubocop:master Jun 18, 2020
@utkarsh2102 utkarsh2102 deleted the add-rubocop-packaging branch June 18, 2020 08:01
@utkarsh2102
Copy link
Member Author

Hi @bbatsov 👋🏻

Once again, thanks for all your work so far! ❤️

I have got a small request to make..

Based on rspec-style-guide, minitest-style-guide, rails-style-guide, and so on, I've created packaging-style-guide, here:
https://github.com/utkarsh2102/packaging-style-guide
(it follows the same style like other guides)

Would you be kind enough to give a little space to host it at rubystyle.guide? So like https://{rspec, minitest, rails}.rubystyle.guide, there'll be https://packaging.rubystyle.guide, too?

Please let me know if there's something more required at my end to make this happen?
It'd really mean a lot to us (the Debian core devs and other d/s maintainers) ❤️

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 19, 2020

I think you'll have to transfer this guide to the RuboCop HQ org (you'll still be it's owner), so I can deploy the HTML to the org's GitHub pages like the other guides.

@utkarsh2102
Copy link
Member Author

Aha, okay. As long as I can keep maintaining this, this won't be a problem!
However, whilst trying to transfer this to the RuboCop HQ org, I get this:
You don’t have the permission to create public repositories on rubocop-hq

How do I proceed from here?

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 19, 2020

I've sent you an invite to join the org. You'll be able to transfer the repo after you accept it.

@utkarsh2102
Copy link
Member Author

Many thanks. The transfer is now done! 🎉

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 20, 2020

@utkarsh2102
Copy link
Member Author

@bbatsov, you're the best, thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants