Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #5953] Fix a false positive for Style/AccessModifierDeclarations #9632

Conversation

koic
Copy link
Member

@koic koic commented Mar 23, 2021

Fixes #5953.

This PR fixes a false positive for Style/AccessModifierDeclarations when using module_function with symbol.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…arations`

Fixes rubocop#5953.

This PR fixes a false positive for `Style/AccessModifierDeclarations`
when using `module_function` with symbol.
@koic koic force-pushed the fix_a_false_positive_for_style_access_modifier_declarations branch from 2fc8da5 to c5913b3 Compare Mar 23, 2021
Copy link

@pboling pboling left a comment

Thank you! 🚀 LGTM

Drenmi
Drenmi approved these changes Mar 24, 2021
@koic koic merged commit 211c017 into rubocop:master Mar 24, 2021
31 checks passed
@koic koic deleted the fix_a_false_positive_for_style_access_modifier_declarations branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants