Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Lint/NumberConversion #9633

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 23, 2021

For example, the following auto-correction test code is invalid syntax:

"1,2,3,foo,5,6,7,8".split(',').map({ |i| Integer(i, 10) })

This PR removes invalid parentheses and auto-corrects it to valid syntax:

"1,2,3,foo,5,6,7,8".split(',').map { |i| Integer(i, 10) }

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

For example, the following auto-correction test code is invalid syntax:

```ruby
"1,2,3,foo,5,6,7,8".split(',').map({ |i| Integer(i, 10) })
```

This PR removes invalid parentheses and auto-corrects it to valid syntax:

```ruby
"1,2,3,foo,5,6,7,8".split(',').map { |i| Integer(i, 10) }
```
def remove_parentheses(corrector, node)
corrector.replace(node.loc.begin, ' ')
corrector.remove(node.loc.end)
end
Copy link
Member

@dvandersluis dvandersluis Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two other remove_parentheses methods defined on various cops (although they work slightly differently in each case) maybe it'd be good to normalize that at some point.

Copy link
Member Author

@koic koic Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I didn't normalize here because each one has different behavior, but I'll look at it separately :-)

Copy link
Member

@dvandersluis dvandersluis left a comment

👍 looks good!

@koic koic merged commit 107624a into rubocop:master Mar 24, 2021
31 checks passed
@koic koic deleted the fix_incorrect_autocorrect_for_lint_number_conversion branch Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants