Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Lint/AmbiguousOperator #9671

Merged

Conversation

@koic
Copy link
Member

@koic koic commented Apr 3, 2021

This PR fixes the following incorrect auto-correct for Style/MethodCallWithArgsParentheses with Lint/AmbiguousOperator.

% cat example.rb
def foo(&block)
  do_something &block
end

% rubocop --only Style/MethodCallWithArgsParentheses,Lint/AmbiguousOperator -a
Inspecting 4 files
..WC

Offenses:

example.rb:2:3: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
parentheses for method calls with arguments.
  do_something &block
  ^^^^^^^^^^^^^^^^^^^
example.rb:2:16: W: [Corrected] Lint/AmbiguousOperator: Ambiguous block
operator. Parenthesize the method arguments if it's surely a block
operator, or add a whitespace to the right of the & if it should be a
binary AND.
  do_something &block
               ^
ripper/example.rb:6:5: C: [Corrected]
Style/MethodCallWithArgsParentheses: Use parentheses for method calls
with arguments.
    raise message
    ^^^^^^^^^^^^^

4 files inspected, 3 offenses detected, 3 offenses corrected

Before

Syntax error with redundant closing parentheses.

% cat example.rb
def foo(&block)
  do_something(&block))
end

% ruby -c example.rb
example.rb:2: syntax error, unexpected ')', expecting end
  do_something(&block))

After

Valid syntax.

% cat example.rb
def foo(&block)
  do_something(&block)
end

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
@koic koic force-pushed the koic:fix_incorrect_autocorrect_for_ambiguous_operator branch from c25939d to 0ef20d2 Apr 3, 2021
This PR fixes the following incorrect auto-correct for
`Style/MethodCallWithArgsParentheses` with `Lint/AmbiguousOperator`.

```console
% cat example.rb
def foo(&block)
  do_something &block
end

% rubocop --only Style/MethodCallWithArgsParentheses,Lint/AmbiguousOperator -a
Inspecting 4 files
..WC

Offenses:

example.rb:2:3: C: [Corrected] Style/MethodCallWithArgsParentheses: Use
parentheses for method calls with arguments.
  do_something &block
  ^^^^^^^^^^^^^^^^^^^
example.rb:2:16: W: [Corrected] Lint/AmbiguousOperator: Ambiguous block
operator. Parenthesize the method arguments if it's surely a block
operator, or add a whitespace to the right of the & if it should be a
binary AND.
  do_something &block
               ^
ripper/example.rb:6:5: C: [Corrected]
Style/MethodCallWithArgsParentheses: Use parentheses for method calls
with arguments.
    raise message
    ^^^^^^^^^^^^^

4 files inspected, 3 offenses detected, 3 offenses corrected
```

## Before

Syntax error with redundant closing parentheses.

```console
% cat example.rb
def foo(&block)
  do_something(&block))
end

% ruby -c example.rb
example.rb:2: syntax error, unexpected ')', expecting end
  do_something(&block))
```

## After

Valid syntax.

```console
% cat example.rb
def foo(&block)
  do_something(&block)
end
```
@koic koic force-pushed the koic:fix_incorrect_autocorrect_for_ambiguous_operator branch from 0ef20d2 to e0342b2 Apr 3, 2021
@koic koic merged commit f4e72bc into rubocop:master Apr 3, 2021
31 checks passed
31 checks passed
@github-actions
windows 2.4
Details
@github-actions
windows 2.5
Details
@github-actions
windows 2.6
Details
@github-actions
windows 2.7
Details
@github-actions
windows 3.0
Details
@github-actions
windows mingw
Details
@mergify
Summary 2 potential rules
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-3.0-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-3.0-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-3.0-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@koic koic deleted the koic:fix_incorrect_autocorrect_for_ambiguous_operator branch Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant