Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop-rake #9813

Merged
merged 1 commit into from Jun 30, 2021
Merged

Add rubocop-rake #9813

merged 1 commit into from Jun 30, 2021

Conversation

@tejasbubane
Copy link
Contributor

@tejasbubane tejasbubane commented May 19, 2021

https://github.com/rubocop/rubocop-rake


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented May 27, 2021

Looks good, but you'll have to fix the broken build.

@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Jun 10, 2021

@tejasbubane ping :-)

@tejasbubane
Copy link
Contributor Author

@tejasbubane tejasbubane commented Jun 27, 2021

Waiting for rubocop/rubocop-rake#37 to be merged.

Gemfile Outdated
@@ -11,6 +11,7 @@ gem 'rspec', '~> 3.7'
# RuboCop Performance upgrade to 1.11 is postponed until
# https://github.com/rubocop/rubocop/pull/9721 will be resolved.
gem 'rubocop-performance', '~> 1.10.0'
gem 'rubocop-rake', '~> 0.5.1'
Copy link
Member

@koic koic Jun 28, 2021

RuboCop Rake 0.6.0 has been released. Can you update to 0.6.0?
https://github.com/rubocop/rubocop-rake/releases/tag/v0.6.0

Suggested change
gem 'rubocop-rake', '~> 0.5.1'
gem 'rubocop-rake', '~> 0.6.0'

tasks/prof.rake Outdated
@@ -10,6 +10,7 @@ namespace :prof do
system cmd
end

desc 'Run Rubocop on itself only if dump does not exist'
Copy link
Member

@koic koic Jun 28, 2021

Suggested change
desc 'Run Rubocop on itself only if dump does not exist'
desc 'Run RuboCop on itself only if dump does not exist'

@tejasbubane tejasbubane requested a review from koic Jun 29, 2021
@koic koic merged commit 02b1b14 into rubocop:master Jun 30, 2021
27 checks passed
@tejasbubane tejasbubane deleted the rubocop-rake branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants