Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Layout/HashAlignment #9897

Conversation

@koic
Copy link
Member

@koic koic commented Jun 30, 2021

Fixes testdouble/standard#306.

This PR fixes an incorrect auto-correct for Layout/HashAlignment when setting EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and using misaligned keyword arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
Fixes testdouble/standard#306.

This PR fixes an incorrect auto-correct for `Layout/HashAlignment` when setting
`EnforcedStyle: with_fixed_indentation` of `Layout/ArgumentAlignment` and using
misaligned keyword arguments.
@koic koic force-pushed the fix_incorrect_autocorrect_for_layout_hash_alignment branch from c5df989 to ad7fbe1 Jun 30, 2021
@bbatsov bbatsov merged commit 1ca14c9 into rubocop:master Jun 30, 2021
27 checks passed
@bbatsov
Copy link
Collaborator

@bbatsov bbatsov commented Jun 30, 2021

Thanks!

@koic koic deleted the fix_incorrect_autocorrect_for_layout_hash_alignment branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants