Port to Ruboto Core #6

Closed
donv opened this Issue Aug 27, 2011 · 11 comments

Projects

None yet

2 participants

@donv
Ruboto member

As of version 0.4, Ruboto Core offers to share the JRuby jars between apps. ruboto-irb should utilize this.

@donv
Ruboto member

@rscottm What is the status of this?

@donv
Ruboto member

@rscottm I have now done a "ruboto update app" on my fork on ruboto-irb and gotten the tests to run. I have also manually tested a few of the scripts, and they all seems to run OK.

Could you review and merge if it is OK?

The next step is then to remove jruby-*.jar from libs .

@donv donv added a commit to donv/ruboto-irb that referenced this issue Jan 1, 2012
@donv donv * Issue #6 Port to Ruboto Core
* Did 'ruboto update app' and tweaked tests to run green
1439242
@rscottm
Ruboto member
@donv donv added a commit to donv/ruboto-irb that referenced this issue Jan 2, 2012
@donv donv * Issue #6 Port to Ruboto Core
* Added tasks for callbacks in rakelib so it survives project updates.
9b503d3
@donv
Ruboto member

I added the Rake tasks for callbacks in rakelib/callbacks.rake so they are automatically loaded into the Rakefile and survive project updates.

I think we should postpone moving IRB to Ruby code until after this release, which I am hoping we do next monday (2012-01-09).

@rscottm
Ruboto member

Ok, I compiled your version (had to switch systems because one is already on SDK 16...build failed). Most scripts run as expected. I'm getting failure from a few of the scripts in the API demo. Those failures seem to have been there before. The difference is in how they fail. The 0.6 version fails with a backtrace in the IRB tab console. The new one fails, prints the backtrace to the logcat, and terminates the script engine (restarts it in IRB without killing the app). My guess is that this is what I changed in Script.java. I'll look into what I change. I'm sure it was just a line or two in how the exception is caught and handled.

@rscottm
Ruboto member

Here's the commit I had added to better handle the exceptions in IRB"

b1b98b3#src/org/ruboto/Script.java

It basically prints the bactrace to an output stream (specified at startup). I used it for exec and for callMethod. The reason I loop through the backtrace is because I kept seeing an error because there was no backtrace. Anyway, this works for IRB, but we need to figure out the best way to handle exceptions for regular ruboto apps and IRB. You put a lot of time into the exception code in Script.java, so let me know you thoughts. I'll take a pass at it when I get a chance, and fix those error in the API script.

@donv donv added a commit to donv/ruboto-irb that referenced this issue Jan 3, 2012
@donv donv * Issue #6 Port to Ruboto Core
* Changed exception handling to log the exception to the given output stream rather than throw a RuntimeException.
f2d0b13
@donv
Ruboto member

I added better exception logging to ruboto and my ruboto-irb fork.

Can you test it and merge if it looks OK?

@donv
Ruboto member

@rscottm Does it look OK now? Can we merge?

@rscottm
Ruboto member
@donv
Ruboto member

Thanks for the merge!

The "p $:" can be removed.

@donv donv closed this Jan 9, 2012
@donv
Ruboto member

I have removed the output in both ruboto and ruboto-irb.

@donv donv added a commit that referenced this issue Jan 29, 2012
@donv donv * Issue #6 Port to Ruboto Core
* Removed the jruby-jars
* Added WriterOutputStream since it is not available form the jruby jars
* Started using EntryPointActivity
82a2b27
@rscottm rscottm added a commit that referenced this issue Feb 2, 2012
@rscottm rscottm Single instance and handle orientation/screenSize changes (Issue #6 P…
…ort to Ruboto Core)
57f8e68
@rscottm rscottm added a commit that referenced this issue Feb 2, 2012
@rscottm rscottm Expose appStarted and fireRubotoActivity to subclasses (Issue #6 Port…
… to Ruboto Core)
4499686
@rscottm rscottm added a commit that referenced this issue Feb 2, 2012
@rscottm rscottm Allow startup without a script or bundle; added rubotoAttachable to b…
…e tested from script (Issue #6 Port to Ruboto Core)
48b6305
@rscottm rscottm added a commit that referenced this issue Feb 2, 2012
@rscottm rscottm Removed ruboto scripts from demo...remains in apk at root (Issue #6 P…
…ort to Ruboto Core)
7d69bb4
@rscottm rscottm added a commit that referenced this issue Feb 2, 2012
@rscottm rscottm Check new rubotoAttachable because IRB is now a subclass of RubotoAct…
…ivity (Issue #6 Port to Ruboto Core)
db78d74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment