Merge my changes #19

Merged
merged 4 commits into from Sep 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

akshay2047 commented Aug 11, 2012

Added fb sharing option, and importing script("txt","rb") from SD card.

Owner

rscottm commented Aug 15, 2012

Akshay, I'm just getting around to looking at this. It compiled fine. I'm not seeing the Facebook share option. I'm not a Facebook user, so it may detect that and just disable. Do you think I should be able to see it anyway? I may need to get someone else to look at it.

I haven't played around with Android's sharing mechanism. Does this use the standard stuff or something custom? (i.e., would this be a path that could be expanded to open up other kinds of sharing (email, dropbox, etc.))

Contributor

akshay2047 commented Aug 17, 2012

You will see the fb share option in the "Scripts" tab, on long item press on a particular script. Yes, you will be able see the option even if you are not logged in, it will then ask you to log in.
Facebook has its own standard classes for fb-share, fb-like, creating custom dialogue, giving errors etc. These classes are kept in "com.facebook.android". The other two classes that I created to connect to facebook are kept in "net.android.facebook".
As of now this share is only on FB.
Did you look at the import option("Import Script"option you get in Menu), written in IRB.java

@akshay2047 akshay2047 commented on the diff Aug 17, 2012

src/org/ruboto/irb/IRB.java
@@ -488,6 +752,15 @@ private void editScript(IRBScript script, Boolean switchTab) {
Toast.LENGTH_SHORT).show();
}
}
+
+ public void neweditScript(String content, Boolean switchTab,String ChosenFileName){
@akshay2047

akshay2047 Aug 17, 2012

Contributor

function that is supplied with contents of file and filename and this data is put in Editor tab contents.

Owner

rscottm commented Aug 17, 2012

Hi Akshy,

I see it now. I was looking in the wrong menu. Uwe indicated that he could
test out the FB stuff after he's done with his conference this weekend.

The import script stuff works well.

There are a few things that need to happen before I merge your changes:

  1. Uwe will test the FB share

  2. I need to merge some updates from Uwe designed to bring IRB in line with
    ruboto 0.8. I also need to address a few issues this raises.

  3. I will update the About sting to give you credit. I should also give
    credit for the facebook code you're using and the icons you've selected
    (for the import code). Please post any information related how those need
    to be credited.

Thanks,
Scott
On Aug 17, 2012 4:19 AM, "Akshay" notifications@github.com wrote:

You get the fb share option in the "Scripts" tab, on long item press on a
particular script. Yes, you will be able see the option even if you are not
logged in, it will then ask you to log in.
Facebook has its own standard classes for fb-share, fb-like, creating
custom dialogue, giving errors etc. These classes are kept in
"com.facebook.android". The other two classes that I created to connect to
facebook are kept in "net.android.facebook".
As of now this share is only on FB.

Did you look at the import option("Import Script"option you get in Menu),
written in IRB.java


Reply to this email directly or view it on GitHubhttps://github.com/ruboto/ruboto-irb/pull/19#issuecomment-7815461.

Contributor

akshay2047 commented Sep 2, 2012

Hi Scott,
Whats up with this merge request..?

Thanks,
Akshay

Owner

rscottm commented Sep 4, 2012

I still need to get Uwe to test the Facebook sharing. Also, I was waiting on your response to how to credit things in the About page:

  1. How would you like to be credited?

  2. How should we credit the Facebook code? (it's probably in the comments)

  3. How doe we need to give credit the icons used?

Owner

donv commented Sep 4, 2012

Testing the FB sharing now. @rscottm I count on you to have the perspective on where Ruboto IRB is going, what its scope is.

Owner

rscottm commented Sep 4, 2012

I'll put together a post on the Google Group with some thoughts. That way
people can discuss it if they have ideas.
On Sep 4, 2012 10:05 AM, "Uwe Kubosch" notifications@github.com wrote:

Testing the FB sharing now. @rscottm https://github.com/rscottm I count
on you to have the perspective on where Ruboto IRB is going, what its scope
is.


Reply to this email directly or view it on GitHubhttps://github.com/ruboto/ruboto-irb/pull/19#issuecomment-8270774.

Owner

donv commented Sep 4, 2012

The FB sharing functions work, and they are a good first step.

@akshay2047 I hope you will develop them further. Especially you need to avoid sharing the same script twice in a row. After sharing the sharing activity should be closed.

@akshay2047 I have my phone already connected to FB, and I really think you should use that instead of forcing me to log in again.

@akshay2047 I hope you can write more of this in Ruby instead of Java.

@rscottm This look sgood enough to merge.

Owner

rscottm commented Sep 4, 2012

On Tue, Sep 4, 2012 at 2:00 PM, Uwe Kubosch notifications@github.comwrote:

@akshay2047 https://github.com/akshay2047 I have my phone already
connected to FB, and I really think you should use that instead of
forcing me to log in again.

The classes Akshay included manage a connection to Facebook. It seems like
the most Android way of doing things is to use the sharing mechanism which
would include the option of sharing via Facebook if the Facebook app is
installed (likely logged in). This would also facilitate other types of
sharing (through email, Dropbox, Google+, etc.). That's the direction we
should head in the future.

It would also help move things into Ruby.

Let's consider this step two. I'll merge this (Step one) later today.

rscottm merged commit e3fc7c5 into ruboto:master Sep 5, 2012

Contributor

akshay2047 commented Sep 6, 2012

@rscottm can you please update the "About string" as well and add my name to the developers list.

And for the Facebook sharing scripts the licences are included in the classes, so I don't see a need to add credit to this.

Owner

rscottm commented Sep 6, 2012

I can do that soon. What credit is required for the images you included to handle the script selection? I'll make both changes at once.

Contributor

akshay2047 commented Sep 6, 2012

Those are the icons of "folder" and "back" button randomly taken from web no credit required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment