Remove legacy.rb (and tests for handle_ methods) #281

Closed
rscottm opened this Issue Nov 11, 2012 · 4 comments

Projects

None yet

2 participants

Owner
rscottm commented Nov 11, 2012

This is mostly about the handle methods. We should be ready to move beyond those.

Owner
donv commented Nov 11, 2012

I totally agree.

@donv donv was assigned Nov 17, 2012
Owner
donv commented Nov 17, 2012

@rscottm How do you feel about removing support for block based definition of primary (EntryPointActivity) activities? I feel they are redundant now that we have class based activities. Also, they add SO much complexity.

Starting block based activities from other activities is something I think we should keep forever.

Owner
rscottm commented Nov 18, 2012

Is this the only situation where the old constant and proc array code is still used? If so, it's worth getting rid of that.

Owner
donv commented Nov 18, 2012

Yes, that is the last case. I'll start getting rid of it.

@donv donv added a commit that referenced this issue Nov 18, 2012
@donv donv * Issues #281 #282 #290 and #291 Remove legacy callback callbacks
* Cover case where a subclass of EntryPointActivity is NOT backed by a RUby script:  IRB
8614f3f
@donv donv closed this Nov 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment