Ruboto should synchronise target in project.properties and targetSdkVersion in AndroidManifest.xml #303

Closed
donv opened this Issue Dec 6, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Owner

donv commented Dec 6, 2012

It is possible to set different values for target in project.properties and targetSdkVersion in AndroidManifest.xml. The result is that you may change the target level in the manifest, but still compile against a different target level set by the project properties. I see this as a fault in the Android SDK.

Ruboto could look at both versions and either give a warning/error message or synch the values. If we synch the values, we need to decide which of the values should be master, or if we shoudl choose the minimum or maximum of the values.

This originated from a support case with @jsilvermdx.

@ruboto @rscottm @jsilvermdx What do you think?

mixflame commented Dec 6, 2012

I support this. This and load time are my own real complaint from here. Will JRuby JIT speed up load time much? (sorry to derail...)

Owner

donv commented Jun 1, 2013

Finally revisiting this one. @jsilvermdx Are you able to explain how this should behave? I can add a warning during "ruboto update" if the values differ.

donv added a commit that referenced this issue Jun 1, 2013

* Issue #303 Ruboto should synchronise target in project.properties a…
…nd targetSdkVersion in AndroidManifest.xml

* Added output stating that the target was changed n the manifest.

@ghost ghost assigned donv Jun 1, 2013

@donv donv closed this Jun 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment