GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
These small fixes enable me to build ruboto using Ruby 1.9. I've seen others hit the same issue in irc.
Fix for ruby1.9 compatibility. Fix for require of relative files in g…
Hi @jeremyd !
Thanks for the patch! I am starting work on getting it merged.
Can you tell me which tests failed before your fix? I have not tested with Ruby 1.9 myself. I will probably add tests configurations for Ruby 1.9 at http://ci.jruby.org/view/Ruboto in the future.
Also, I think adding a specific check for Ruby 1.9.1 will get cluttered when we later add more cases. I think you can just replace 1.8/1.9.1 with an asterisk (*). That will catch the JRuby 1.7 variant "shared" as well. Can you change that?
It failed when running rake gem to build the ruboto gem. "rake gem". I'll see if I can find a solution that covers all rubies.
I have started testing with multiple Rubies at http://ci.jruby.org/view/Ruboto As soon as the tests are running reliably, I'll merge and verify your changes.
@jeremyd could you pull the latest changes form master and refresh your pull request so it can be merged automatically?
@jeremyd I added all your changes to master. Check it out!
@jeremyd thanks for your contribution. Would you like to join the Ruboto project? Commit rights and glory await you!
Sure! :) How do I join the project more than already?
Sure! :) How do I join the project more than already? (wrong account in previous comment)