Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

'b' frames are being decoded using a PACK_INT8 (signing the bits) #40

Closed
ghost opened this Issue · 1 comment

1 participant

@ghost

AMQP 'b' frames are being converted to a signed short short,
it should be changed in lib/amq/protocol/table_value_decoder.rb to

...
def self.decode_short_short(data, offset)
  v = data.slice(offset, 1).unpack(PACK_CHAR).first
  offset += 1
  [v, offset]
end
...

PACK_INT8 vs PACK_CHAR.

(Note this is called from the TableValueDecoder which calls it via line 53: when TYPE_SIGNED_8BIT then this should probably be reflected all the way up to be unsigned.)

A pull request will be made shortly

@michaelklishin

Fixed in #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.