Fix framing issue in the encode_body() method #34

Merged
merged 1 commit into from Sep 17, 2013

Conversation

Projects
None yet
2 participants
Contributor

nviennot commented Sep 17, 2013

When the payload is frame_size - 8, encode_body generate an extra frame of 0 length. This makes RabbitMQ angry.

Contributor

nviennot commented Sep 17, 2013

Related to ruby-amqp/bunny#154

@michaelklishin michaelklishin added a commit that referenced this pull request Sep 17, 2013

@michaelklishin michaelklishin Merge pull request #34 from nviennot/master
Fix framing issue in the encode_body() method
b3a68ff

@michaelklishin michaelklishin merged commit b3a68ff into ruby-amqp:master Sep 17, 2013

1 check passed

default The Travis CI build passed
Details
Owner

michaelklishin commented Sep 17, 2013

I will cut a new release later today (BST). Thank you very much!

Contributor

nviennot commented Sep 17, 2013

Great!
Thank you :)

@nviennot nviennot added a commit to promiscuous-io/promiscuous that referenced this pull request Nov 4, 2013

@nviennot nviennot AMQP frame size issue test 4e81f4d

@kareemk kareemk pushed a commit to promiscuous-io/promiscuous that referenced this pull request Nov 4, 2013

@michaeldauria michaeldauria Ensure we're on amq-protocol >= 1.8.0
This version brings in a fix for messages that are
exactly the same size as frame_max - 8

ruby-amqp/amq-protocol#34
ruby-amqp/bunny#154
05b441b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment