fixed single bite conversion from signed to unsigned for 'b' frames #41

Merged
merged 1 commit into from Dec 19, 2013

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Dec 19, 2013

A fix regarding issue #40

michaelklishin added a commit that referenced this pull request Dec 19, 2013

Merge pull request #41 from OtherLevels/issue_40
fixed single bite conversion from signed to unsigned for 'b' frames

@michaelklishin michaelklishin merged commit a988b44 into ruby-amqp:1.9.x-stable Dec 19, 2013

1 check failed

default The Travis CI build failed
Details
@michaelklishin

This comment has been minimized.

Show comment Hide comment
@michaelklishin

michaelklishin Dec 19, 2013

Member

OK, I had to revert this. Please make sure all tests pass and CI does not fail.

Member

michaelklishin commented Dec 19, 2013

OK, I had to revert this. Please make sure all tests pass and CI does not fail.

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 19, 2013

Sorry about that Michael, I've now made sure that all the tests pass. (changed the decode_short_short test to decode_byte)

ghost commented Dec 19, 2013

Sorry about that Michael, I've now made sure that all the tests pass. (changed the decode_short_short test to decode_byte)

@michaelklishin

This comment has been minimized.

Show comment Hide comment
@michaelklishin

michaelklishin Dec 19, 2013

Member

I still get a failure:

1.9.x-stable* be rspec spec/
zsh: correct 'rspec' to 'spec' [nyae]? n
Running on 2.0.0
..............................................................................................................................................................................................................F............................................................................................................................................................................................................

Failures:

  1) AMQ::Protocol::Table.decode is capable of decoding 8bit unsigned integers
     Failure/Error: output = TableValueDecoder.decode_byte("\xC0",0).first
     NoMethodError:
       undefined method `decode_byte' for AMQ::Protocol::TableValueDecoder:Class
     # ./spec/amq/protocol/table_spec.rb:179:in `block (3 levels) in <module:Protocol>'

Finished in 0.13812 seconds
411 examples, 1 failure
Member

michaelklishin commented Dec 19, 2013

I still get a failure:

1.9.x-stable* be rspec spec/
zsh: correct 'rspec' to 'spec' [nyae]? n
Running on 2.0.0
..............................................................................................................................................................................................................F............................................................................................................................................................................................................

Failures:

  1) AMQ::Protocol::Table.decode is capable of decoding 8bit unsigned integers
     Failure/Error: output = TableValueDecoder.decode_byte("\xC0",0).first
     NoMethodError:
       undefined method `decode_byte' for AMQ::Protocol::TableValueDecoder:Class
     # ./spec/amq/protocol/table_spec.rb:179:in `block (3 levels) in <module:Protocol>'

Finished in 0.13812 seconds
411 examples, 1 failure
@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Dec 19, 2013

Ah, I think maybe it's isolated 215253a as a cherry pick (as it never updated the changes to fix this bug in this pull request). It looks like github ignores changes on a branch after its been merged (even if it is rejected thereafter?). Should I drop this pull request and see it if picks up all the changes on a new pull request?

ghost commented Dec 19, 2013

Ah, I think maybe it's isolated 215253a as a cherry pick (as it never updated the changes to fix this bug in this pull request). It looks like github ignores changes on a branch after its been merged (even if it is rejected thereafter?). Should I drop this pull request and see it if picks up all the changes on a new pull request?

@michaelklishin

This comment has been minimized.

Show comment Hide comment
@michaelklishin

michaelklishin Dec 19, 2013

Member

Yes, just push another branch and submit it.

Member

michaelklishin commented Dec 19, 2013

Yes, just push another branch and submit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment