[Issue #40 resubmission] 'b' frame decoding changed from int8 to char (uint8) #42

Merged
merged 10 commits into from Dec 20, 2013

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Dec 19, 2013

Resubmission for changes regarding issue #40 (this time ruby-amqp/master <-> OtherLevels/issue_40_resubmission)

@@ -1,5 +1,5 @@
module AMQ
module Protocol
- VERSION = "1.10.0.pre1"
+ VERSION = "1.9.2.pre"

This comment has been minimized.

@michaelklishin

michaelklishin Dec 20, 2013

Member

It is never OK to change version in a pull request.

@michaelklishin

michaelklishin Dec 20, 2013

Member

It is never OK to change version in a pull request.

michaelklishin added a commit that referenced this pull request Dec 20, 2013

Merge pull request #42 from OtherLevels/issue_40_resubmission
[Issue #40 resubmission] 'b' frame decoding changed from int8 to char (uint8)

@michaelklishin michaelklishin merged commit 79b3728 into ruby-amqp:master Dec 20, 2013

1 check passed

default The Travis CI build passed
Details

michaelklishin added a commit that referenced this pull request Dec 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment