Skip to content
Permalink
Branch: master
Commits on Jun 5, 2018
  1. Remove tls_ca_certificates variable

    Ana06 committed Jun 5, 2018
    `tls_ca_certificates` is only used once and it may be that it is not
    even used depending on the `if` condition. Instead of assign it, we can
    just call the method when it is needed.
  2. Remove empty certificates log error

    Ana06 committed Jun 5, 2018
    As the default ones are added afterwards and this message may be
    confusing.
  3. Use OpenSSL::X509::Store#set_default_paths

    Ana06 committed Jun 5, 2018
    Use `OpenSSL::X509::Store#set_default_paths` to add default certificates
    instead of reimplementing this method in
    `Transport#default_tls_certificates`. See:
    https://ruby-doc.org/stdlib-2.5.0/libdoc/openssl/rdoc/OpenSSL/X509/Store.html#method-i-set_default_paths
    
    `Transport#default_tls_certificates`, appart from the work to maintain
    the code, had several problems:
    - It didn't work for JRuby
    - It didn't work for openSUSE, as `ca-bundle.pem` doesn't exist anymore
You can’t perform that action at this time.