Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Recovery attempts limit is never reset #408
Something interesting seems to be happening with recovery. There's a line that decrements attempts but no accompanying reset. However, channel operations seem to recover on their own even when the number of attempts is set low.
Not a huge deal, but thought I'd record this thought before forgetting it.
I agree that this may be counterintuitive to most and decided to change it. One issue with
Previous behehavior is not unreasonable but is not what many users and even RabbitMQ team members come to expect. Therefore it can be treated as a bug. Previously a reconnection counter was preserved between successful recoveries. This made the integration test that uses server-sent connection.close possible. With this change, the counter is reset after successful reconnection but there's an option to go back to the original behavior. We also do a hell of a lot more logging. Note that connection.close recovery with a running node will no longer work for testing this functionality. There aren't may ways to stop and start the node that aren't environment-specific, perhaps one day we will mess with nodes in Bunny tests and introduce a replacement test. References fff7f44.