Allow work pools that abort on Exception. #382

Merged
merged 1 commit into from Feb 26, 2016

Conversation

Projects
None yet
2 participants
@seamusabshere
Contributor

seamusabshere commented Feb 25, 2016

Some users may prefer the consumer work pool bubble up exceptions.

Allow work pools that abort on Exception.
Some users may prefer the consumer work pool bubble up exceptions.

@michaelklishin michaelklishin self-assigned this Feb 25, 2016

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Feb 25, 2016

Member

Thank you, this looks good, I will take a closer look tomorrow.

Member

michaelklishin commented Feb 25, 2016

Thank you, this looks good, I will take a closer look tomorrow.

@seamusabshere

This comment has been minimized.

Show comment
Hide comment
@seamusabshere

seamusabshere Feb 25, 2016

Contributor

needed for gocardless/hutch#196

thanks @michaelklishin ! thanks for bearing with me!

Contributor

seamusabshere commented Feb 25, 2016

needed for gocardless/hutch#196

thanks @michaelklishin ! thanks for bearing with me!

@michaelklishin michaelklishin merged commit 56d00dc into ruby-amqp:master Feb 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@seamusabshere seamusabshere deleted the seamusabshere:optional-abort-on-exception branch Feb 26, 2016

eebs added a commit to eebs/bunny-mock that referenced this pull request Dec 19, 2016

Allow Session#create_channel to accept additional args
In ruby-amqp/bunny#382 and ruby-amqp/bunny#437 `Session#create_channel` got some additional arguments. This change allows calling of `create_channel` with additional arguments.

@eebs eebs referenced this pull request in eebs/bunny-mock Dec 19, 2016

Closed

Allow Session#create_channel to accept additional args #1

eebs added a commit to eebs/bunny-mock that referenced this pull request Dec 19, 2016

Allow Session#create_channel to accept additional args
In ruby-amqp/bunny#382 and
ruby-amqp/bunny#437 `Session#create_channel` got
some additional arguments. This change allows calling of
`create_channel` with additional arguments.

@eebs eebs referenced this pull request in arempe93/bunny-mock Dec 19, 2016

Closed

Allow Session#create_channel to accept additional args #27

arempe93 added a commit to arempe93/bunny-mock that referenced this pull request Apr 10, 2017

Allow Session#create_channel to accept additional args
In ruby-amqp/bunny#382 and
ruby-amqp/bunny#437 `Session#create_channel` got
some additional arguments. This change allows calling of
`create_channel` with additional arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment