Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Raise when calling wait_for_confirms on a closed channel #428
I'm proposing this change based on the discussion and feedback I got in #425.
If a channel is already closed it will receive no new frames and waiting
If one wishes to wait for confirmations it’s probably the case that the
If a channel is already closed it will receive no new frames and waiting for confirmations will most likely hang and timeout unless the frames were somehow already received. If one wishes to wait for confirmations it’s probably the case that the user doesn’t expect the channel to be closed and we should notify them about it by failing early. A channel might be closed by RabbitMQ in case of a channel-level error for example due to a publishing error.