Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTreat string and symbols the same when specifying 'server' or :server #524
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tyronewilson
Oct 24, 2017
Contributor
I closed the other one as there were conflicts. This is the right one now.
|
I closed the other one as there were conflicts. This is the right one now. |
tyronewilson
closed this
Oct 24, 2017
tyronewilson
reopened this
Oct 24, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Doh..... clicking too fast. Sorry |
michaelklishin
merged commit 8224499
into
ruby-amqp:2.7.x-stable
Oct 24, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thank you. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
tyronewilson
Oct 24, 2017
Contributor
My pleasure :)
…On 24 Oct 2017 17:33, "Michael Klishin" ***@***.***> wrote:
Thank you.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#524 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB0EctHQD1_yK2JXYWIzr9BgRJqnrlpqks5svgNUgaJpZM4QEmrd>
.
|
My pleasure :)
…On 24 Oct 2017 17:33, "Michael Klishin" ***@***.***> wrote:
Thank you.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#524 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB0EctHQD1_yK2JXYWIzr9BgRJqnrlpqks5svgNUgaJpZM4QEmrd>
.
|
added a commit
that referenced
this pull request
Oct 25, 2017
michaelklishin
referenced this pull request
Oct 30, 2017
Closed
fix ruby warnings and remove obviously unused code #526
michaelklishin
added this to the 2.8.0 milestone
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tyronewilson commentedOct 24, 2017
When loading config values from yaml file you can't easily pass in a symbol like :server. So this PR treats 'server' the same as :server so that string values can be used from .yml files.