New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat string and symbols the same when specifying 'server' or :server #524

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@tyronewilson
Contributor

tyronewilson commented Oct 24, 2017

When loading config values from yaml file you can't easily pass in a symbol like :server. So this PR treats 'server' the same as :server so that string values can be used from .yml files.

@tyronewilson

This comment has been minimized.

Show comment
Hide comment
@tyronewilson

tyronewilson Oct 24, 2017

Contributor

I closed the other one as there were conflicts. This is the right one now.

Contributor

tyronewilson commented Oct 24, 2017

I closed the other one as there were conflicts. This is the right one now.

@tyronewilson

This comment has been minimized.

Show comment
Hide comment
@tyronewilson

tyronewilson Oct 24, 2017

Contributor

Doh..... clicking too fast. Sorry

Contributor

tyronewilson commented Oct 24, 2017

Doh..... clicking too fast. Sorry

@michaelklishin michaelklishin merged commit 8224499 into ruby-amqp:2.7.x-stable Oct 24, 2017

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Oct 24, 2017

Member

Thank you.

Member

michaelklishin commented Oct 24, 2017

Thank you.

@tyronewilson

This comment has been minimized.

Show comment
Hide comment
@tyronewilson

tyronewilson Oct 24, 2017

Contributor
Contributor

tyronewilson commented Oct 24, 2017

michaelklishin added a commit that referenced this pull request Oct 25, 2017

Re-apply #524 in master
Contributed by @tyronewilson.

Merging with -s ours ignored a commit that should have had no conflicts :/

@michaelklishin michaelklishin added this to the 2.8.0 milestone Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment