Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix incompatibility with JRuby 9K - #356 #529
Merged
Conversation
This switches back to the CPU heavy read_nonblock since readpartial randomly hangs in JRuby [0]. It also fixes the private method #open called in JRuby by redefining it in the Socket module. Yet another fix is to rescue EOFError [1]. [0] - https://gist.github.com/knewter/5818005 [1] - jruby/jruby#1694 (comment)
michaelklishin
merged commit a0ec9e5
into
ruby-amqp:master
1 check passed
1 check passed
|
Thank you. I will backport to |
|
I have this same issue, thank you @dakull. Also, buna! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently bunny doesn't work at all with JRuby 9K - when trying to connect it fails with the behaviour described in #356.
This PR fixes that plus a couple of more issues, the integration specs are fully green but the full specs fail so this should be regarded as WIP + feedback on the changes.
Yes we have a valid option for JRuby (March Hare gem) but it would be nice for Bunny at least to function with JRuby 9K even if that implies a bigger overhead than native Java libs - Im thinking for some smaller apps having the full Bunny gem API might be useful.