/bunny

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with JRuby 9K - #356 #529

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.8.0
3 participants
@marianposaceanu @michaelklishin @mach-kernel
@marianposaceanu
Contributor

marianposaceanu commented Nov 16, 2017 •
edited

Currently bunny doesn't work at all with JRuby 9K - when trying to connect it fails with the behaviour described in #356.

This PR fixes that plus a couple of more issues, the integration specs are fully green but the full specs fail so this should be regarded as WIP + feedback on the changes.

Yes we have a valid option for JRuby (March Hare gem) but it would be nice for Bunny at least to function with JRuby 9K even if that implies a bigger overhead than native Java libs - Im thinking for some smaller apps having the full Bunny gem API might be useful.
@marianposaceanu
Fix incompatibility with JRuby 9K 
This switches back to the CPU heavy read_nonblock since readpartial
randomly hangs in JRuby [0]. It also fixes the private method #open
called in JRuby by redefining it in the Socket module. Yet another
fix is to rescue EOFError [1].

[0] - https://gist.github.com/knewter/5818005
[1] - jruby/jruby#1694 (comment)
a5618a4

@michaelklishin michaelklishin merged commit a0ec9e5 into ruby-amqp:master Nov 17, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Nov 17, 2017

Member

Thank you. I will backport to 2.7.x.
Member

michaelklishin commented Nov 17, 2017

Thank you. I will backport to 2.7.x.
@mach-kernel

This comment has been minimized.

Show comment
Hide comment
@mach-kernel

mach-kernel Nov 20, 2017

I have this same issue, thank you @dakull. Also, buna!

mach-kernel commented Nov 20, 2017

I have this same issue, thank you @dakull. Also, buna!

@michaelklishin michaelklishin added this to the 2.8.0 milestone Dec 18, 2017

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Dec 18, 2017

Member

Released in 2.8.0, will do a 2.7.3 later today.
Member

michaelklishin commented Dec 18, 2017

Released in 2.8.0, will do a 2.7.3 later today.

@roback roback referenced this pull request Feb 9, 2018

Open

JRuby support? #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment