Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log level warn instead of error ... #531

Merged

Conversation

@nevesenin
Copy link

@nevesenin nevesenin commented Nov 20, 2017

... when automatic connection recovery is enabled

Our log management system creates alerts for messages with log level "error". When automatic connection recovery is enabled this doesn't feel right, because handling the exception is the expected behavior.

@michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 20, 2017

I have things to say about changing libraries due to the way a single company decided to set up log monitoring. However, using a warning when recovery is enabled is fine, so maybe I'll share it some other time.

@michaelklishin michaelklishin merged commit 2123545 into ruby-amqp:master Nov 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michaelklishin michaelklishin added this to the 2.8.0 milestone Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.