New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commits chart data #214

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@bmarkons
Copy link
Collaborator

bmarkons commented Jun 19, 2017

Commit messages containing ruby like string interpolation syntax were causing problem with chart categories and tooltips.

On ruby side messages are being received escaped \#{ ... } which caused error in javascript on JSON.parse. So before drawing chart I removed those escapements.

I struggled a bit with this but got help https://stackoverflow.com/questions/44630300/why-jquery-cant-parse-inside-array-string/44630468#44630468

@bmarkons bmarkons force-pushed the bmarkons:fix-graph-tooltip branch from a6e9dd0 to 3eaa31e Jun 19, 2017

@bmarkons bmarkons added the bug label Jun 19, 2017

@bmarkons bmarkons changed the title Fix chart categories Fix commits chart data Jun 19, 2017

@tgxworld tgxworld merged commit 1d9163a into ruby-bench:master Jun 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgxworld

This comment has been minimized.

Copy link
Member

tgxworld commented Jun 19, 2017

Thank you for fixing :) Feel free to deploy your changes

@bmarkons bmarkons added GSOC gsoc2017 and removed bug GSOC labels Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment