Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display range of commits that are untested when clicking on a point. #26

Merged
merged 1 commit into from Feb 18, 2015

Conversation

tgxworld
Copy link
Member

#25

@tgxworld
Copy link
Member Author

@SamSaffron I've thrown up an initial implementation. Is this what you were looking for? I'm using GitHub's API here so rate limit is going to be an issue and I've not thought of a solution for it yet.

Normal Range

screenshot from 2015-02-16 23 35 57

Edge Cases

screenshot from 2015-02-16 23 36 07

@tgxworld
Copy link
Member Author

bloggif_54e21192dba1a

@tgxworld
Copy link
Member Author

@SamSaffron Instead of pulling all the commit details from GitHub's API, I decided to just link to the repo's compare. I very much prefer this method as compared to the first.

screenshot from 2015-02-17 10 40 47

@SamSaffron
Copy link
Member

lets play with both and see which one we like better

@tgxworld
Copy link
Member Author

Ok I'll push the second one up first to avoid having to deal with GitHub's rate limit.

@tgxworld tgxworld changed the title [WIP] Display range of commits that are untested when clicking on a point. Display range of commits that are untested when clicking on a point. Feb 18, 2015
tgxworld added a commit that referenced this pull request Feb 18, 2015
Display range of commits that are untested when clicking on a point.
@tgxworld tgxworld merged commit 36d4056 into master Feb 18, 2015
@tgxworld tgxworld deleted the improve_click_commit_feature branch March 31, 2015 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants