Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DEPRECATION WARNING about deprecated sass @extend .a.b in application.scss #1044

Merged

Conversation

qichunren
Copy link
Member

And &.active { @extend .btn-default.active } is not need,
because it already extend .btn-default and will auto extend .btn-default.active

DEPRECATION WARNING on line 524 of /home/xxxx/homeland/app/assets/stylesheets/application.scss:
Extending a compound selector, .btn-default.active, is deprecated and will not be supported in a future release.
Consider "@extend .btn-default, .active" instead.
See sass/sass#1599 for details.

这个extend不需要声明了,前面已经extend .btn-default了,会自动extend .btn-default的.active,我在浏览器中前后对比了,发现删除这个,生成的css是没有变的,所以我的改动是可行的,并且消除了DEPRECATION WARNING

And &.active { @extend .btn-default.active } is not need,
because it already extend .btn-default and will auto extend .btn-default.active

这个extend不需要声明了,前面已经extend .btn-default了,会自动extend .btn-default的.active,我在浏览器中前后对比了,发现删除这个,生成的css是没有变的,所以我的改动是可行的,并且消除了DEPRECATION WARNING
@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         131      131           
  Lines        5890     5890           
=======================================
  Hits         5800     5800           
  Misses         90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f1528...31a85ef. Read the comment docs.

@huacnlee huacnlee merged commit 6577259 into ruby-china:master Jun 4, 2018
@qichunren qichunren deleted the fix_sass_extend_deprecated_warning branch October 13, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants