clean up a few warnings #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bare `*` is ambiguous, so I added parens to make it unambiguous. Also I removed some unused assignments. I don't know how to turn on warnings for RSpec, so I just ran the tests like this: ``` RUBYOPT=-w be rake spec ```
Member
|
Thank you! I couldn't figure out another way, either, so I added While we're chatting, the other day we started seeing a segfault from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bare
*is ambiguous, so I added parens to make it unambiguous.Also I removed some unused assignments.
I don't know how to turn on warnings for RSpec, so I just ran the tests
like this: