New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use supported TruffleRuby APIs #765

Merged
merged 2 commits into from Oct 10, 2018

Conversation

2 participants
@chrisseaton
Member

chrisseaton commented Oct 9, 2018

No description provided.

@wafflebot wafflebot bot added the in progress label Oct 9, 2018

@chrisseaton chrisseaton requested a review from pitr-ch Oct 9, 2018

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Oct 9, 2018

Member

I've updated TR version to rc7.

Member

pitr-ch commented Oct 9, 2018

I've updated TR version to rc7.

@chrisseaton

This comment has been minimized.

Show comment
Hide comment
@chrisseaton

chrisseaton Oct 9, 2018

Member

Did you need to update to RC 7? I didn't understand the failures. Are any of them an issue?

I added shims both ways - TruffleRuby still provides the old methods, and Concurrent Ruby defines the new methods using the old ones if the new ones are missing. Should avoid anyone being inconvenienced.

Member

chrisseaton commented Oct 9, 2018

Did you need to update to RC 7? I didn't understand the failures. Are any of them an issue?

I added shims both ways - TruffleRuby still provides the old methods, and Concurrent Ruby defines the new methods using the old ones if the new ones are missing. Should avoid anyone being inconvenienced.

@pitr-ch

This comment has been minimized.

Show comment
Hide comment
@pitr-ch

pitr-ch Oct 10, 2018

Member

Sorry for confusion. I just needed updating. The changes are fine. The failures are rather result of badly written c-r tests, it's too sensitive to timing.

Member

pitr-ch commented Oct 10, 2018

Sorry for confusion. I just needed updating. The changes are fine. The failures are rather result of badly written c-r tests, it's too sensitive to timing.

@pitr-ch pitr-ch merged commit 10ec86f into master Oct 10, 2018

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 10, 2018

@pitr-ch pitr-ch deleted the truffleruby-api branch Oct 10, 2018

@pitr-ch pitr-ch added the enhancement label Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment