Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds file option to config_set to allow adding to specific git-config files #458

Merged
merged 4 commits into from Jun 19, 2021

Conversation

codenamev
Copy link
Contributor

@codenamev codenamev commented Mar 4, 2020

PR checklist

  • Review the guidelines for contributing to this repository.
  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

There are many git configurations that are preferred to keep in a separate file to avoid committing sensitive information (in a global dotfile as an example). This updates the .config method to accept a file option that allows you to specify the file to save the configuration to (this is equivalent to git config --file some/custom/config name value).

… files

Signed-off-by: Valentino Stoll <v@codenamev.com>
@stale
Copy link

@stale stale bot commented May 3, 2020

A friendly reminder that this issue had no activity for 60 days.

@stale stale bot added the stale label May 3, 2020
@stale stale bot removed the stale label Nov 10, 2020
@codenamev
Copy link
Contributor Author

@codenamev codenamev commented Nov 10, 2020

@jcouball from the contributing docs it says to request a review from a maintainer. I'm not entirely sure on the process for doing that (outside of pinging you directly like this). If there is a preference of process I'd be happy to document it 😄 I'm unable to request a review via the typical GitHub UI.

@stale
Copy link

@stale stale bot commented Jun 11, 2021

A friendly reminder that this issue had no activity for 60 days.

@stale stale bot added the stale label Jun 11, 2021
@stale stale bot removed the stale label Jun 11, 2021
@codenamev
Copy link
Contributor Author

@codenamev codenamev commented Jun 14, 2021

@perlun @tarcinil @jcouball Any interest in this feature?

@perlun
Copy link
Contributor

@perlun perlun commented Jun 15, 2021

@perlun @tarcinil @jcouball Any interest in this feature?

Sorry for the lack of feedback. This project is rather unmaintained at the moment; @jcouball was the last one to review a merge request. James, would you have a chance to give this a look?

Copy link
Member

@jcouball jcouball left a comment

Apologies for taking so long to get to this. This addition looks great!

The only thing it is missing is an entry in the README. I'll add this if I don't see a PR in the next day or two.

I'll plan on cutting a new minor-version release within the next week to get this in the gem.

@jcouball jcouball merged commit 765df7c into ruby-git:master Jun 19, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants