-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --gpg-sign option on commits #518
Conversation
Signed-off-by: othmane399 <othmane.elmassari@doctolib.com>
6816f04
to
7690399
Compare
@jcouball can you review this PR please ? it's about to add --gpg-sign flag on commit method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this PR. I have a couple of requests:
- I suggest that the key passed to
Git::Lib#commit
be 'gpg_sign' instead of just 'sign'. I think it is important to keep this close to the git CLI. I know this hasn't been done consistently, but I think it is a good idea. - I suggest, since we are here, allow passing an optional as documented in git-commit. If the value of the key is
true
don't append the"=#{keyid}"
to the argument.
Optional (if you don't do this, I can follow up with a separate PR for it):
- Add a test so that calling commit builds the command correctly. I'd stub out
command
for this test. - Add documentation to the README.md for this option.
Signed-off-by: othmane399 <othmane.elmassari@doctolib.com>
@jcouball thx for your review. I've done what you have recommended, can you recheck ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the requested changes. I follow up with a PR to:
- Add a test so that calling commit builds the command correctly. I'd stub out command for this test.
- Add documentation to the README.md for this option.
I plan on building a new minor release within the next week to get this code into the gem.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This pull request add and option on
opts
hash to sign your commits using the default key that has been set in the config file