Refactor how working, repository, and index directories are initialized #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
When opening a submodule or secondary working tree which exist in a directory different than the current directory, the command would fail. Fixes #541.
The logic for how to set working tree, repository, and index directories is scattered all over the place. This PR tries to centralize that logic.
The PR also fixes a bug where a new
Git.init
was creating a new bare repository in the.git
directory of the given directory rather than directly in the given directory. That is the reason the tests needed to be changed.