Store tempfile objects to prevent deletion during tests #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
This allows the truffleruby-head CI to pass. I believe this is currently failing because the
tempfile_object
is being finalized and deleting the file at the corresponding path while the file at the path is still being used during the test. The problem here is similar to what is described here:ruby-git/lib/git/lib.rb
Line 984 in 735b083
This solution holds the tempfiles in an array to ensure they are not removed until the
Array#clear
method is called after the test is run.Alternative solutions:
tempfile_object.close!
- This would prevent the issue but the path wouldn't be cleaned up after the test. The paths could be tracked and removed manually.