Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store tempfile objects to prevent deletion during tests #555

Merged
merged 1 commit into from Jan 6, 2022

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Jan 5, 2022

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This allows the truffleruby-head CI to pass. I believe this is currently failing because the tempfile_object is being finalized and deleting the file at the corresponding path while the file at the path is still being used during the test. The problem here is similar to what is described here:

# delete it now, before we write to it, so that Ruby doesn't delete it
.

This solution holds the tempfiles in an array to ensure they are not removed until the Array#clear method is called after the test is run.

Alternative solutions:

  • call tempfile_object.close! - This would prevent the issue but the path wouldn't be cleaned up after the test. The paths could be tracked and removed manually.

Signed-off-by: Brandon Fish <brandon.j.fish@oracle.com>
@bjfish bjfish changed the title Delete tempfile so files at this path are not deleted during tests Store tempfile objects to prevent deletion during tests Jan 5, 2022
Copy link
Member

@jcouball jcouball left a comment

Nice! I noticed the occasional failures. I am glad you stepped up with a solution. What you did makes a lot of sense. Thank you.

@jcouball jcouball merged commit 12e3d03 into ruby-git:master Jan 6, 2022
7 of 8 checks passed
@bjfish bjfish deleted the truffleruby-ci-fix branch Jan 6, 2022
@jcouball jcouball mentioned this pull request Jan 6, 2022
3 tasks
@jcouball jcouball mentioned this pull request Jan 6, 2022
3 tasks
@jcouball jcouball mentioned this pull request Jan 6, 2022
3 tasks
p-mongo pushed a commit to p-mongodb/ruby-git that referenced this issue May 27, 2022
鈥' into mine

* p/diff-submodule: (36 commits)
  Support --submodule option to git diff.
  Support the --all option for git fetch (ruby-git#583)
  Workaround to get JRuby build working (ruby-git#582)
  Update README.md (ruby-git#580)
  Make the directory param to Git.clone optional (ruby-git#578)
  Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577)
  Add Git::URL #parse and #clone_to methods (ruby-git#575)
  Use the head version of yard (ruby-git#573)
  Release v1.11.0
  Supress unneeded test output (ruby-git#570)
  Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563)
  Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566)
  remove from maintainer (ruby-git#567)
  Address command line injection in Git::Lib#fetch
  Release v1.10.2 (ruby-git#561)
  Add create-release, setup, and console dev scripts (ruby-git#560)
  Store tempfile objects to prevent deletion during tests (ruby-git#555)
  Release v1.10.1 (ruby-git#553)
  Properly escape double quotes in shell commands on Windows (ruby-git#552)
  Properly unescape diff paths (ruby-git#504)
  ...

* p/set-url-push: (36 commits)
  Add :push option to remote_set_url.
  Support the --all option for git fetch (ruby-git#583)
  Workaround to get JRuby build working (ruby-git#582)
  Update README.md (ruby-git#580)
  Make the directory param to Git.clone optional (ruby-git#578)
  Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577)
  Add Git::URL #parse and #clone_to methods (ruby-git#575)
  Use the head version of yard (ruby-git#573)
  Release v1.11.0
  Supress unneeded test output (ruby-git#570)
  Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563)
  Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566)
  remove from maintainer (ruby-git#567)
  Address command line injection in Git::Lib#fetch
  Release v1.10.2 (ruby-git#561)
  Add create-release, setup, and console dev scripts (ruby-git#560)
  Store tempfile objects to prevent deletion during tests (ruby-git#555)
  Release v1.10.1 (ruby-git#553)
  Properly escape double quotes in shell commands on Windows (ruby-git#552)
  Properly unescape diff paths (ruby-git#504)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants