Fix bug when grepping lines that contain numbers surrounded by colons #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Fairbairn jamesaf112@gmail.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Recently I discovered a bug where the
grep
function was not parsing certain lines correctly. In particular, lines that contained a digit surrounded by colons. For example, take the following file:If you called
grep('example')
, it would return incorrect file paths including theexample
and the line number would be20
.Upon exploring this issue, I discovered that it was due to the regex used for parsing. Effectively, the first capture group needed to be greedy to fix the issue.