Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Ruby 3.2 #573

Merged
merged 1 commit into from Apr 18, 2022
Merged

Fix build on Ruby 3.2 #573

merged 1 commit into from Apr 18, 2022

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Apr 18, 2022

Signed-off-by: James Couball jcouball@yahoo.com

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This PR fixes the ruby-head build (Ruby 3.2) which fails because yard calls Ruby's taint API. lsegal/yard#1419 fixes this issue in yard which was merged months ago but there has not yet been a new release of yard.

Rather than live with the ruby-head builds failing for the git gem, this PR installs yard from the Github main branch. This is a temporary work around which should be removed after yard releases a new version that includes the fix for taint.

More info on the taint API in Ruby:

In Ruby 2.7, the taint checking mechanism was removed. Object#taint, Object#trust, Object#untaint, Object#untrust and related functions in the C-API have been made no-op methods. It means they do nothing and just return self.

In Ruby 3.2, Object#taint, Object#trust, Object#untaint, Object#untrust and the C functions have been completely removed.

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball changed the title Use the head version of yard Fix build on Ruby 3.2 Apr 18, 2022
@jcouball jcouball merged commit 0a43d8b into master Apr 18, 2022
@jcouball jcouball deleted the use_yard_head branch April 28, 2022 23:19
p-mongo pushed a commit to p-mongodb/ruby-git that referenced this pull request May 27, 2022
鈥' into mine

* p/diff-submodule: (36 commits)
  Support --submodule option to git diff.
  Support the --all option for git fetch (ruby-git#583)
  Workaround to get JRuby build working (ruby-git#582)
  Update README.md (ruby-git#580)
  Make the directory param to Git.clone optional (ruby-git#578)
  Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577)
  Add Git::URL #parse and #clone_to methods (ruby-git#575)
  Use the head version of yard (ruby-git#573)
  Release v1.11.0
  Supress unneeded test output (ruby-git#570)
  Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563)
  Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566)
  remove from maintainer (ruby-git#567)
  Address command line injection in Git::Lib#fetch
  Release v1.10.2 (ruby-git#561)
  Add create-release, setup, and console dev scripts (ruby-git#560)
  Store tempfile objects to prevent deletion during tests (ruby-git#555)
  Release v1.10.1 (ruby-git#553)
  Properly escape double quotes in shell commands on Windows (ruby-git#552)
  Properly unescape diff paths (ruby-git#504)
  ...

* p/set-url-push: (36 commits)
  Add :push option to remote_set_url.
  Support the --all option for git fetch (ruby-git#583)
  Workaround to get JRuby build working (ruby-git#582)
  Update README.md (ruby-git#580)
  Make the directory param to Git.clone optional (ruby-git#578)
  Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577)
  Add Git::URL #parse and #clone_to methods (ruby-git#575)
  Use the head version of yard (ruby-git#573)
  Release v1.11.0
  Supress unneeded test output (ruby-git#570)
  Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563)
  Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566)
  remove from maintainer (ruby-git#567)
  Address command line injection in Git::Lib#fetch
  Release v1.10.2 (ruby-git#561)
  Add create-release, setup, and console dev scripts (ruby-git#560)
  Store tempfile objects to prevent deletion during tests (ruby-git#555)
  Release v1.10.1 (ruby-git#553)
  Properly escape double quotes in shell commands on Windows (ruby-git#552)
  Properly unescape diff paths (ruby-git#504)
  ...
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant