Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the model of the returned Gtk::TreeIter #466

Merged
merged 2 commits into from Jun 28, 2015

Conversation

cedlemo
Copy link
Contributor

@cedlemo cedlemo commented Jun 26, 2015

Setup the model of the resulting Gtk::TreeIter returned by Gtk::ListStore#prepend

Fix this kind of pb:

model = Gtk::ListStore.new(TrueClass, String)
model.prepend.set_values([true, "item5"])

that returns:

/home/cedlemo/.gem/ruby/2.2.0/gems/gtk3-2.2.6/lib/gtk3/tree-iter.rb:38:in `set_values': undefined method `set_values' for nil:NilClass (NoMethodError)

@cedlemo
Copy link
Contributor Author

cedlemo commented Jun 26, 2015

I think that all the methods that return a Gtk::TreePath need to be modified this way. I am okay to add them.Furthermore I think that the test file should be modified/simplified (remove all assert_nothing_raised as you show me in 2e8f549 ). Tell me if you are ok with this and /or if you have any advices.

kou added a commit that referenced this pull request Jun 28, 2015
Setup the model of the returned Gtk::TreeIter

Patch by cedlemo. Thanks!!!
@kou kou merged commit f32bb9a into ruby-gnome:master Jun 28, 2015
@kou
Copy link
Member

kou commented Jun 28, 2015

Thanks!

I think that all the methods that return a Gtk::TreePath need to be modified this way.

You're right.

I am okay to add them.

It's very helpful. Please do it!

Furthermore I think that the test file should be modified/simplified (remove all assert_nothing_raised as you show me in 2e8f549 ).

You're right. We should remove them.

Tell me if you are ok with this and /or if you have any advices.

OK! I have no advice. I think that you understand all of them correctly. :-)

@cedlemo cedlemo deleted the gtk3_lib_list_store_rb branch July 5, 2015 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants