[#498] Dry up OPTIONS regression #573

Closed
etehtsea opened this Issue Feb 7, 2014 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

etehtsea commented Feb 7, 2014

This pull request broke OPTIONS for endpoints mounted inside root app with version.

Link to demo app

Owner

dblock commented Feb 7, 2014

Could you please write a test for this in Grape proper? Appreciate it.

@dblock dblock added the bug? label Feb 7, 2014

Owner

dblock commented Feb 7, 2014

etehtsea added a commit to SPBTV/grape that referenced this issue Feb 7, 2014

Contributor

etehtsea commented Feb 7, 2014

@dblock I added failing spec, but I need feedback where the proper place for it and how to name it.

Owner

dblock commented Feb 7, 2014

I think its location is fine. Now can you fix it? :)

Contributor

karlfreeman commented Feb 16, 2014

Thought I'd chime in on this.

Giving this a quick look at, I'm able to reproduce the error with this test karlfreeman/grape@109d4e3 (eg the first test passes, whereas the second doesn't). It appears that using path versioning with a mounted api fails. I'm not going to be able to commit the time to fix this but figured I'd see if it was something simple.

@dblock dblock added confirmed bug and removed bug? labels Feb 16, 2014

@dblock dblock closed this in 65a3056 Feb 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment