Add stream method to InsideRoute to leverage Rack::Chunked
#1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbelzer
force-pushed
the
support_streaming
branch
from
46bcec8
to
9e4acb5
Compare
|
Very good @zbelzer! Will merge. |
|
The build is failing on Rubocop you have some fixes to do, please (via |
|
Oh rubocop... |
… Rack::Chunked. Also necessary was the introduction of an object (`FileResponse`) so the formatting middleware would leave files and other enumerables alone.
zbelzer
force-pushed
the
support_streaming
branch
from
9e4acb5
to
8e2d247
Compare
|
There a preferable way to update that Module length? |
|
I run |
dblock
added a commit
that referenced
this pull request
Jul 30, 2015
Add `stream` method to InsideRoute to leverage Rack::Chunked
|
Merged |
|
Thanks! I ran that but it looked like it threw a fit. Maybe if I had run again it would have been happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also necessary was the introduction of an object (
FileResponse) so the formatting middleware would leave files and other enumerables alone. Seemed better than relying on methods on the object as enumerables haveeachdefined. I've been writing scala recently so I think I have case classes on the brain.