Support ruby 2.4 #1543
Merged
Support ruby 2.4 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Support for Ruby 2.4 will have to be called out in README and CHANGELOG since it doesn't work out of the box. |
namusyaka
force-pushed
the
support-ruby-2.4
branch
from
3b41eeb
to
8eaf3af
Compare
namusyaka
force-pushed
the
support-ruby-2.4
branch
from
8eaf3af
to
5d0aeb9
Compare
LeFnord
reviewed
Dec 27, 2016
| @@ -7,6 +7,16 @@ matrix: | |||
| - rvm: 2.3.3 | |||
There was a problem hiding this comment.
please can you change it to 2.4.0
|
👍 … thanks |
namusyaka
force-pushed
the
support-ruby-2.4
branch
from
5d0aeb9
to
1828fde
Compare
namusyaka
force-pushed
the
support-ruby-2.4
branch
from
1828fde
to
96fd175
Compare
namusyaka
commented
Dec 27, 2016
| #=> Integer in ruby 2.4 | ||
| #=> Fixnum in earlier ruby versions | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Added Integer/Fixnum and Corcions section. Could you review this ?
|
|
||
| * [#1536](https://github.com/ruby-grape/grape/pull/1536): Updates `invalid_versioner_option` translation - [@Lavode](https://github.com/Lavode). | ||
| * [#1543](https://github.com/ruby-grape/grape/pull/1543): Support ruby 2.4 - [@LeFnord](https://github.com/LeFnord), [@namusyaka](https://github.com/namusyaka). |
|
… it seems, it could be mörged … |
dblock
reviewed
Dec 28, 2016
| module Spec | ||
| module Support | ||
| module Helpers | ||
| INTEGER_CLASS_NAME = 0.to_i.class.to_s.freeze |
|
Merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixnum is deprecated now, so I guess we should drop Fixnum and use Integer instead.
@dblock @dm1try Thoughts?