Avoid duplicated calls in StackableValue#[] #1561

Merged
merged 2 commits into from Jan 26, 2017

Conversation

Projects
None yet
4 participants
@brucehsu
Contributor

brucehsu commented Jan 26, 2017

Fixing the performance issue mentioned in issue #1560 by eliminating duplicated calls of StackableValue#[] in one-liner conditionals.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

coveralls commented Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

Coverage Status

Coverage remained the same at 99.071% when pulling 061cf11 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into 3b91395 on ruby-grape:master.

@brucehsu

This comment has been minimized.

Show comment
Hide comment
@brucehsu

brucehsu Jan 26, 2017

Contributor

Travis-CI builds are failing on Ruby 2.3.3 and Ruby 2.4, due to this issue in Rainbow 2.2.1 : sickill/rainbow#48

Contributor

brucehsu commented Jan 26, 2017

Travis-CI builds are failing on Ruby 2.3.3 and Ruby 2.4, due to this issue in Rainbow 2.2.1 : sickill/rainbow#48

@brucehsu

This comment has been minimized.

Show comment
Hide comment
@brucehsu

brucehsu Jan 26, 2017

Contributor

Please also refer to: travis-ci/travis-ci#7204

Contributor

brucehsu commented Jan 26, 2017

Please also refer to: travis-ci/travis-ci#7204

@brucehsu

This comment has been minimized.

Show comment
Hide comment
@brucehsu

brucehsu Jan 26, 2017

Contributor

Fixed in PR #1562 .

Contributor

brucehsu commented Jan 26, 2017

Fixed in PR #1562 .

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Jan 26, 2017

Member

This makes a lot of sense. Rebase (I merged #1562) please, and add a CHANGELOG line in line with something like "Improved performance of ..." so that it becomes a visible change.

Member

dblock commented Jan 26, 2017

This makes a lot of sense. Rebase (I merged #1562) please, and add a CHANGELOG line in line with something like "Improved performance of ..." so that it becomes a visible change.

@grape-bot

This comment has been minimized.

Show comment
Hide comment
@grape-bot

grape-bot Jan 26, 2017

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

coveralls commented Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

coveralls commented Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 26, 2017

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

Coverage Status

Coverage remained the same at 99.071% when pulling 882eb65 on brucehsu:feature/fix_excessive_recursion_in_stackablevalue into b4858f3 on ruby-grape:master.

@dblock dblock merged commit e1a14bf into ruby-grape:master Jan 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Jan 26, 2017

Member

Thanks @brucehsu. I'll make a minor release sometime soon.

Member

dblock commented Jan 26, 2017

Thanks @brucehsu. I'll make a minor release sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment