-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect feature #166
Add redirect feature #166
Conversation
I like it. You also need to document it in the README. I would change redirect to take an optional code and default it to nil, which causes it to be a 302/303. People might want permanent redirects and stuff like that (304). |
@dblock thanks. let me change it |
I am going to nitpick, but since we're at it, do you think it's worth changing Leaving this open for a couple of days before merging! Speak up if you have an opinion. |
@dblock I've considered it before, I think user will do permanent redirect in web server in most of the case, so I use |
I meant like this: def redirect(url, options = {})
# permanent redirect if options[:permanent]
end That is if we think there will be more to options than permanent vs. non-permanent? |
This looks great! Lets get it merged :) |
Merged, thank you for your cooperation. |
No description provided.