Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support security in desc block #1831

Merged
merged 4 commits into from
Dec 3, 2018

Conversation

fotos
Copy link
Contributor

@fotos fotos commented Dec 3, 2018

Adds support for security in desc block.

Proposing the change since options hash parameters are marked as deprecated and the bug in ruby-grape/grape-swagger#706 prevents using both (options are not merged into the block).

desc `Create User` do
  security [
    # security schemes
  ]
  # …
end

Includes some minor formatting changes in the spec (in separate commits) and I didn't update the README.md since it already points to grape-swagger for more info.

Related to #1791 and (slightly) to ruby-grape/grape-swagger#729.

@dblock dblock merged commit 45bc7e3 into ruby-grape:master Dec 3, 2018
@dblock
Copy link
Member

dblock commented Dec 3, 2018

Looks good, merged.

@fotos fotos deleted the support-security-in-desc-block branch December 3, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants