Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upget rid of a needless step in HashWithIndifferentAccess #1940
Conversation
There was an extra operation in `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder` it is unnecessary, people already use Rails 4, 5 or 6. Devs who are on Rails 3 less likely will upgrade to latest Grape. After removing that operation Grape consumes less memory. Before: 36080 bytes After: 32472 bytes
This comment has been minimized.
This comment has been minimized.
grape-bot
commented
Dec 3, 2019
•
Generated by |
This comment has been minimized.
This comment has been minimized.
|
So effectively by doing this we're removing support for Rails 3? Which we didn't really talk about before or test against. Maybe we want to be extra cautious and write it in UPGRADING or CHANGELOG? I'll merge this as is though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dnesteryuk commentedDec 3, 2019
There was an extra operation in
Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilderit is unnecessary, people already use Rails 4, 5 or 6. Devs who are on Rails 3 less likely will upgrade to latest Grape.After removing that operation Grape consumes less memory.
Before: 36080 bytes
After: 32472 bytes