Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveSupport::JSON is super slow #397

Closed
stereobooster opened this issue Nov 9, 2017 · 3 comments
Closed

ActiveSupport::JSON is super slow #397

stereobooster opened this issue Nov 9, 2017 · 3 comments

Comments

@stereobooster
Copy link
Contributor

stereobooster commented Nov 9, 2017 •
edited

ActiveSupport::JSON is known to be super slow https://github.com/stereobooster/ruby-json-benchmark

What we can do is replace it with multi_json or add optional dependency for oj which has compatible mode with rails and fallback to ActiveSupport::JSON if oj not available.

Thanks! ❤️
@radar
Copy link
Collaborator

radar commented Nov 9, 2017

Patches welcome

@stereobooster stereobooster mentioned this issue Nov 10, 2017
Merged
@stevebissett
Copy link

This is no longer an issue because #398 is merged. Can we close it?

@radar radar closed this as completed Jan 5, 2018
@radar
Copy link
Collaborator

radar commented Jan 5, 2018

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@radar @stereobooster @stevebissett