Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't allow nil to be submitted as a key to i18n.translate()" #370

Merged
merged 1 commit into from May 31, 2017

Conversation

@radar
Copy link
Collaborator

@radar radar commented May 31, 2017

Reverts #236

@radar radar merged commit f331b76 into master May 31, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@radar radar deleted the revert-236-nil_errors branch May 31, 2017
@radar
Copy link
Collaborator Author

@radar radar commented May 31, 2017

Reverting this as it broke cancancan: CanCanCommunity/cancancan#415

@jcstringer: I think that because cancancan relies on this feature, we should leave it the behaviour as it was. Interested to hear your thoughts on this too.

@jcstringer
Copy link
Contributor

@jcstringer jcstringer commented May 31, 2017

@radar I get it with cancancan being a popular gem and such but for the record my 2 cents is that we should not support passing nil as a key and that raising the error makes sense. There is some chatter in the related cancancan issue to that effect. So if the proposed change on that end is ever made it would be nice to see this work merged back in here.

CanCanCommunity/cancancan#415

@clemens
Copy link
Collaborator

@clemens clemens commented May 31, 2017

I'm also working on a fix for cancancan since IMO it's an issue on their side, not on i18n's. See here: CanCanCommunity/cancancan#416.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants