This change introduce a regression. Here is the regression test:
diff --git a/test/backend/fallbacks_test.rb b/test/backend/fallbacks_test.rb index 23e4713..a220c03 100644 --- a/test/backend/fallbacks_test.rb +++ b/test/backend/fallbacks_test.rb @@ -64,6 +64,10 @@ class I18nBackendFallbacksTranslateTest < I18n::TestCase assert_nil I18n.t(:missing_bar, :locale => :'de-DE', :default => nil) end + test "returns the translation missing message if the default is also missing" do + assert_equal 'translation missing: de-DE.missing_bar', I18n.t(:missing_bar, :locale => :'de-DE', :default => [:missing_baz]) + end + test "returns the :'de-DE' default :baz translation for a missing :'de-DE' when defaults contains Symbol" do assert_equal 'Baz in :de-DE', I18n.t(:missing_foo, :locale => :'de-DE', :default => [:baz, "Default Bar"]) end
radar added a commit to rafaelfranca/i18n that referenced this pull request
Nov 2, 2017
When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message. Before this commit we were showing a translation missing error in the "no key" key. This commit fixes a regression introduced in ruby-i18n#387.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.